fix(groups): use atomic operation for memberCount on member removal#15607
Open
edvinasetherel wants to merge 1 commit intoHabitRPG:developfrom
Open
fix(groups): use atomic operation for memberCount on member removal#15607edvinasetherel wants to merge 1 commit intoHabitRPG:developfrom
edvinasetherel wants to merge 1 commit intoHabitRPG:developfrom
Conversation
Replace read-modify-write pattern with MongoDB's $inc operator to prevent race conditions when multiple members are removed concurrently. Refactored removeGroupMember controller with helper functions and added integration tests to verify consistent member counts under concurrent operations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #12286
Changes
removeGroupMemberwherememberCountcould become inconsistent under concurrent removals$incupdate formemberCountfieldNotes
This PR addresses
removeGroupMemberonly. Other group endpoints that modifymemberCountare intentionally out of scope to keep the change minimaland easy to review
UUID:
ddbb1bd4-bb04-4798-8d69-02e77ad7ff71