Conversation
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (5)
definitions/output/reports/reports_dynamic.js:5
- Replace the hardcoded date with a constant or variable to avoid magic numbers.
const startDate = '2024-12-01' // constants.currentMonth;
definitions/output/reports/reports_dynamic.js:6
- Replace the hardcoded date with a constant or variable to avoid magic numbers.
const endDate = '2024-12-01' // constants.currentMonth;
includes/reports.js:25
- The term 'lense' is incorrectly spelled. It should be 'lens'.
date = '${params.date}' ${params.devRankFilter} ${params.lense.sql} AND
includes/reports.js:51
- The term 'lense' is incorrectly spelled. It should be 'lens'.
date = '${params.date}' ${params.devRankFilter} ${params.lense.sql} AND
infra/bigquery-export/reports.js:46
- Modifying this.storagePath directly can lead to unintended side effects. Consider resetting this.storagePath to its original value after the export is completed.
this.storagePath = this.storagePath + `${exportData.lense}/`
|
@tunetheweb would this be easier to maintain? |
| drupal: 'AND \'Drupal\' IN UNNEST(technologies.technology)', | ||
| magento: 'AND \'Magento\' IN UNNEST(technologies.technology)', | ||
| wordpress: 'AND \'WordPress\' IN UNNEST(technologies.technology)' |
There was a problem hiding this comment.
Need to think how this works for reports that don't look at page dataset. But maybe that's only CrUX and that's why you've excluded those for now?
There was a problem hiding this comment.
Yeah, we'll start using the new approach faster this way + need to identify all additional customizations required before further adjustments.
Maybe it will be easier to get breakdowns by 8 lenses per report in one query (as we do in tech report) instead of 8.
Docs
I added only crawl lenses support to the reports, CrUX will follow after we migrate these.
Examples of bytesTotal (cached on CDN):