Skip to content

use pyproj.toml, src layout#677

Open
bhazelton wants to merge 27 commits intomainfrom
update_packaging
Open

use pyproj.toml, src layout#677
bhazelton wants to merge 27 commits intomainfrom
update_packaging

Conversation

@bhazelton
Copy link
Member

Description

This is a modernization/reorganization to a src layout (allows better testing) and using pyproj.toml instead of setup.py to define the package (the current setup.py approach is deprecated).

I actually did this work several months ago but was waiting for #675 to be merged to get this in.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Schema change (any change to the SQL tables)
  • New feature without schema change (non-breaking change which adds functionality)
  • Change associated with a change in redis structure
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Version change
  • Build or continuous integration change
  • Other

Checklist:

Build or continuous integration change checklist:

  • If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.

Other:

  • My code follows the code style of this project.
  • I understand the updates required onsite (detailed in the readme) and I will make those
    changes when this is merged.
  • Unit tests pass on site (This is a critical check, CI can differ from site).
  • I have updated the CHANGELOG.

david-deboer
david-deboer previously approved these changes Sep 24, 2025
Copy link
Contributor

@david-deboer david-deboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. The only question is the url. postgresql -> postgresql+psycopg. I'm assuming that is correct and then not related to the CI having issues?

@bhazelton
Copy link
Member Author

Looks fine to me. The only question is the url. postgresql -> postgresql+psycopg. I'm assuming that is correct and then not related to the CI having issues?

I think it was a mistake. That change should only be made for sqlalchemy access to postgres, not to the actual postgres server. I fixed it and it's making it past that step (there's a new error I'm working on). Thanks for pointing it out!

also apply branch version fixes developed in rasg repos
Also removed that from example configs as I think the configs should be tied to the true postgres url not to the sqlalchemy url hack.

And fixed a test that let a test table persist in the test database, which caused sqlite parse errors.
@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.59%. Comparing base (340072a) to head (1e0835b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
- Coverage   98.13%   97.59%   -0.55%     
==========================================
  Files          34       34              
  Lines        5312     5312              
==========================================
- Hits         5213     5184      -29     
- Misses         99      128      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

.coveragerc Outdated
omit =
*/tests/*
*/docs/*
branch = false
Copy link
Member Author

@bhazelton bhazelton Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

punted turning this on, made an issue for now (#679)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants