feat: fixes and CI pipeline improvements#120
Open
reuben-geonet wants to merge 20 commits intoH3rz3n:mainfrom
Open
feat: fixes and CI pipeline improvements#120reuben-geonet wants to merge 20 commits intoH3rz3n:mainfrom
reuben-geonet wants to merge 20 commits intoH3rz3n:mainfrom
Conversation
This avoids the per-OS version explosion of if/else branching, making it easier to support more OS versions. If you want to still be able to say "hey, we only support up to Fedora 42", then you can easily introduce a check against the `version_num` detected. You might do that with with a dictionary with as key the OS name and as value the highest supported version (or a list of supported versions if the range is not contiguous).
Author
|
Not quite sure on the process for upload to copr. If you just give it the tarball. Could also create a GH aciton for it. Currently each matrix uploads its tarball as an artifact but this could possible be removed depending if its needed or not for COPR. Also need to fix an issue with the README file location. |
reuben-geonet
force-pushed
the
gh-actions
branch
7 times, most recently
from
b2997ec to
5f3052d
Compare
squash: b677f2d
reuben-geonet
force-pushed
the
gh-actions
branch
2 times, most recently
from
b7a49d2 to
618b80f
Compare
reuben-geonet
force-pushed
the
gh-actions
branch
from
618b80f to
65a14e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #118
based on #117 so merge that PR in first
Changes