Skip to content

refactor[cartesian]: fix some type errors in frontend#2564

Open
romanc wants to merge 3 commits intoGridTools:mainfrom
romanc:romanc/mypy-def-ir-to-gtir
Open

refactor[cartesian]: fix some type errors in frontend#2564
romanc wants to merge 3 commits intoGridTools:mainfrom
romanc:romanc/mypy-def-ir-to-gtir

Conversation

@romanc
Copy link
Copy Markdown
Contributor

@romanc romanc commented Apr 1, 2026

Description

This PR changes the flat out "ignore all mypy errors" on defir_to_gtir and nodes with a more targeted ignore that only filters "call-arg" errors. These are generated by @attribclass classes, which - apparently - aren't understood by mypy.

In a follow-up PR, we can probably replace @attribclass classes with @dataclass classes. Those seem to serve a similar purpose and are natively understood by mypy.

Requirements

  • All fixes and/or new features come with corresponding tests.
  • Important design decisions have been documented in the appropriate ADR inside the docs/development/ADRs/ folder.
    N/A

@romanc romanc requested a review from FlorianDeconinck April 1, 2026 15:34
@romanc romanc changed the title refactor[cartesian]: fix some type errors in defir_to_gtir refactor[cartesian]: fix some type errors in frontend Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant