chore: Port core functional logic for Spring Boot 4.0 / Spring Framework 7.0 upgrade#4313
Conversation
- Upgrade Spring Boot to 4.0.0 and Spring Cloud to 2025.1.0 - Update documentation and remove legacy .jdk8 markers
| this.datastoreOperations = datastoreOperations; | ||
| } | ||
|
|
||
| public DatastoreQueryLookupStrategy( |
There was a problem hiding this comment.
this seems like a breaking change, is there a reason why you're removing it?
There was a problem hiding this comment.
The QueryMethodEvaluationContextProvider has been deprecated in Spring Data 2025.01 release notes in favor of ValueExpressionDelegate so we can only support ValueExpressionDelegate.
There was a problem hiding this comment.
thanks! can you keep track of breaking changes we made to the API so we can include them in the release notes.
Something like:
removed DatastoreQueryLookupStrategy constructor due to spring data removal of QueryMethodEvaluationContextProvider. Users should migrate to DatastoreQueryLookupStrategy
...va/com/google/cloud/spring/data/datastore/repository/query/DatastoreQueryLookupStrategy.java
Show resolved
Hide resolved
| * @param evaluationContextProvider the provider used to evaluate SpEL expressions in queries. | ||
| * @param datastoreMappingContext used for getting metadata about entities. | ||
| */ | ||
| public GqlDatastoreQuery( |
There was a problem hiding this comment.
removing public methods is a breaking change, is there a reason this has to be removed?
There was a problem hiding this comment.
The QueryMethodEvaluationContextProvider has been deprecated in Spring Data 2025.01 release notes in favor of ValueExpressionDelegate so we can only support ValueExpressionDelegate which means removing this constructor.
There was a problem hiding this comment.
same here, lets keep track of the breaking changes for release notes
...src/main/java/com/google/cloud/spring/data/datastore/repository/query/GqlDatastoreQuery.java
Show resolved
Hide resolved
| * SpannerTemplate, ValueExpressionDelegate, SpelExpressionParser)} instead. | ||
| */ | ||
| @Deprecated | ||
| public SpannerQueryLookupStrategy( |
There was a problem hiding this comment.
i think we can remove since it was already deprecated, but flagging to confirm with @jinseopkim0
| * SpannerTemplate, ValueExpressionDelegate, SpelExpressionParser)} instead. | ||
| */ | ||
| @Deprecated | ||
| SqlSpannerQuery( |
There was a problem hiding this comment.
flagging removal of deprecated method
There was a problem hiding this comment.
also lets note in release notes
a9fffd3
into
GoogleCloudPlatform:8.0-migration
This PR addresses the core functional changes required to upgrade the project to Spring Boot 4.0 and Spring Framework 7.0. The focus was on surgically resolving compilation failures and breaking API changes while maintaining strict consistency with the project's established Java 8 syntax and formatting conventions.
Key Changes:
Spring Data 4.0 Migration:
Spring Framework 7.0 Refactoring:
Spring Security 7.0 DSL Update:
Autoconfigure & Dependency Management:
Technical Implementation Details
Testing Performed