Fix broken cache_refresh behavior when groups are disabled.#181
Merged
google-oss-prow[bot] merged 4 commits intoGoogleCloudPlatform:masterfrom Feb 27, 2026
Merged
Fix broken cache_refresh behavior when groups are disabled.#181google-oss-prow[bot] merged 4 commits intoGoogleCloudPlatform:masterfrom
google-oss-prow[bot] merged 4 commits intoGoogleCloudPlatform:masterfrom
Conversation
This change introduces a new binary cache format for storing OS Login passwd information. It includes: - `OsLoginPasswdCacheWriter`: A C++ class to build and write the cache file. It buffers user entries, sorts them, and writes them to a temporary file before atomically renaming it. - `oslogin_passwd_cache_reader`: A C implementation for reading from the cache file using mmap. It provides functions compatible with NSS modules for looking up entries by UID, name, and iterating through all entries. - `eytzinger_layout.h`: A template function to convert a sorted vector into an Eytzinger layout, used for the name index to improve cache locality during lookups. - `oslogin_index_structs.h`: Defines the structures used for the UID and Name indices. - New unit tests (`eytzinger_layout_test.cc`, `oslogin_passwd_cache_reader_test.cc`, `round_trip_test.cc`) to validate the cache functionality, including concurrent read access. - The `Makefile` is updated to build and run the new tests. The `main` function is removed from `oslogin_utils_test.cc` as `gtest_main.cc` is now linked.
When groups are disabled, this can cause the return value to be -1, and this can break the guest agent.
ChaitanyaKulkarni28
approved these changes
Feb 27, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anandadalton, ChaitanyaKulkarni28 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 5ec79d4
into
GoogleCloudPlatform:master
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.