Skip to content

Update packaging as of Ubuntu devel packaging#130

Open
utkarsh2102 wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
utkarsh2102:update-debian-packaging
Open

Update packaging as of Ubuntu devel packaging#130
utkarsh2102 wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
utkarsh2102:update-debian-packaging

Conversation

@utkarsh2102
Copy link

Hello,

This PR is an initiative to align the Debian packaging of guest-oslogin in Ubuntu and upstream (here).

The diff represents the changes we have in Ubuntu. I'm forwarding them here as they're all relevant and follow the standard Debian packaging practices. These changes are what we have in Ubuntu devel (current development branch).

These changes change how packaging is done and don't affect the resulting binaries (that is, there is no functional change).

Please let me know if you have any questions or concerns.

@google-oss-prow google-oss-prow bot requested review from ajorg and jjerger February 7, 2024 09:13
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: utkarsh2102
Once this PR has been reviewed and has the lgtm label, please assign chaitanyakulkarni28 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

Hi @utkarsh2102. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zmarano zmarano requested review from a-crate and dorileo and removed request for ajorg and jjerger May 23, 2024 16:14
@utkarsh2102 utkarsh2102 force-pushed the update-debian-packaging branch from 8f29dd0 to 098f1e4 Compare September 24, 2024 07:58
@google-oss-prow google-oss-prow bot added size/XL and removed size/L labels Sep 24, 2024
@utkarsh2102
Copy link
Author

@dorileo @a-crate, hey, this is ready for your review! :)

@a-crate
Copy link
Contributor

a-crate commented Sep 24, 2024

LGTM. @dorileo ?

@dorileo
Copy link
Contributor

dorileo commented Nov 14, 2024

/lgtm

@dorileo
Copy link
Contributor

dorileo commented Nov 14, 2024

/ok-to-test

@a-crate a-crate removed their request for review January 25, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants