Skip to content

take metadata endpoint from config file#127

Open
IlyaMar wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
IlyaMar:metadata_server_config_endpoint
Open

take metadata endpoint from config file#127
IlyaMar wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
IlyaMar:metadata_server_config_endpoint

Conversation

@IlyaMar
Copy link

@IlyaMar IlyaMar commented Dec 29, 2023

Read metadata endpoint from /etc/google_oslogin.conf.
Use default 169.254.169.254 if config not found or not readable.
Read config once on .so load.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: IlyaMar
Once this PR has been reviewed and has the lgtm label, please assign chaitanyakulkarni28 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

Hi @IlyaMar. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dorileo
Copy link
Contributor

dorileo commented Feb 26, 2024

Hi @IlyaMar what are you trying to achieve wit this change? How would a user benefit from this feature? What would be the use case?

Thanks,
Leo

@IlyaMar
Copy link
Author

IlyaMar commented Mar 27, 2024

Hi @IlyaMar what are you trying to achieve wit this change? How would a user benefit from this feature? What would be the use case?

Thanks, Leo

Hi Leo, sorry for a long delay. This is not for a user, rather for a developer to be able to test component against a mock endpoint that listens on localhost. Another possible case is migration to a new endpoint to avoid old endpoint shutdown and oslogin downtime.

@a-crate a-crate removed their request for review January 25, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants