Add port field to database connection dialog#2201
Open
jlaustill wants to merge 1 commit intoGnucash:stablefrom
Open
Add port field to database connection dialog#2201jlaustill wants to merge 1 commit intoGnucash:stablefrom
jlaustill wants to merge 1 commit intoGnucash:stablefrom
Conversation
The PostgreSQL connection dialog only exposed host, database, username, and password fields, with no way to specify a non-standard port. The backend already fully supports custom ports but always received 0 from the dialog, causing it to default to 5432. This is a problem for managed database services (Digital Ocean, AWS RDS, etc.) that commonly use non-standard ports. Add a Port entry field to the database connection dialog with placeholder text showing the default (5432). When left blank, behavior is unchanged. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gnc_uri_create_uri()anddbi_conn_set_option_numeric()— this change wires up the UI to pass the port through instead of hardcoding0Motivation
Managed database services (Digital Ocean, AWS RDS, Google Cloud SQL, etc.) commonly use non-standard ports. There was no way to specify a port in the connection dialog, making it impossible to connect to these services without workarounds.
Changes
gnucash/gtkbuilder/dialog-file-access.glade— Added Port label and entry field (row 4) with placeholder text "Default: 5432"gnucash/gnome-utils/dialog-file-access.c— Addedtf_porttoFileAccessWindowstruct, reads port value ingeturl(), passes it tognc_uri_create_uri()Test plan