Skip to content

D3 sankey#2112

Draft
christopherlam wants to merge 4 commits intoGnucash:stablefrom
christopherlam:d3-sankey
Draft

D3 sankey#2112
christopherlam wants to merge 4 commits intoGnucash:stablefrom
christopherlam:d3-sankey

Conversation

@christopherlam
Copy link
Copy Markdown
Contributor

For entertainment. Has enormous tech debt! 😮

  • uses an old D3.js v3 which is still ES5 compatible, increases chances of WIN32 compatibility
  • uses an old D3-sankey which is compatible with D3v3
  • html-sankey offers a thin wrapper similar to html-chart
  • cashflow-sankey uses html-sankey
Screenshot 2025-07-15 at 23-23-35 Cash Flow Sankey Chart

@jralls
Copy link
Copy Markdown
Member

jralls commented Jul 15, 2025

 Syntax error:
standard/cashflow-sankey.scm:132:4: definition in expression context, where definitions are not allowed, in form (define all-flows (hash-map->list cons totals-hash))

That aside, the lack of color in the screenshot makes it impossible to interpret the chart. Is that an artifact or a limitation from the antiquity of the dependencies?

@christopherlam christopherlam force-pushed the d3-sankey branch 4 times, most recently from 381a4f8 to 5719ca2 Compare July 16, 2025 00:48
@christopherlam
Copy link
Copy Markdown
Contributor Author

That aside, the lack of color in the screenshot makes it impossible to interpret the chart. Is that an artifact or a limitation from the antiquity of the dependencies?

Dunno... what colour is missing? It's likely customisable via the js string.

@jralls
Copy link
Copy Markdown
Member

jralls commented Jul 16, 2025

Most sankey charts I see have colors for the source categories to make it easier to see how much of which source end up at each sink. I thought the #759 chart was like that but when I looked at it just now I see that it only has gradients in place of the blue bars in this one. Prettier but not more usable.

@christopherlam christopherlam marked this pull request as ready for review July 16, 2025 14:36
@christopherlam christopherlam marked this pull request as draft July 16, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants