[HA-61] feat(visitors)/ Enable visitors mode during away mode#161
[HA-61] feat(visitors)/ Enable visitors mode during away mode#161
Conversation
This commit enables the visitors mode to work correctly when the house is in away mode. Specifically, when 'input_boolean.visitors' is ON: - The garage door power remains ON (or is turned back ON) if the house is in away mode. - The camera sirens and notifications remain OFF (or are turned OFF) if the house is in away mode. This is achieved by updating: - 'Block the garage door when we are away' in 'automations.yaml'. - 'Turn on/off camera when we are away' in 'automations.yaml'. - 'Garage: Turn off power if user moves away after pre-arrival' in 'automations/away_mode.yaml'. - 'automations/visitors.md' documentation. Co-authored-by: Giom-V <3638972+Giom-V@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of ChangesHello @Giom-V, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the home automation system's "away mode" logic to gracefully handle scenarios where visitors are present. It ensures that critical functions like garage door power and camera alerts behave as expected when Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully implements the 'visitors mode' logic for the garage door and camera security settings. By adding input_boolean.visitors as a condition and trigger, the automations now correctly ensure that if guests are present, the garage door power remains active and security measures (sirens and notifications) are disabled, even when the house is in 'away mode'. The documentation has also been updated to reflect these changes. I have suggested a minor improvement to consolidate triggers in automations.yaml for better maintainability.
| - trigger: state | ||
| entity_id: | ||
| - input_boolean.away_mode | ||
| - trigger: state | ||
| entity_id: | ||
| - input_boolean.visitors |
There was a problem hiding this comment.
The triggers for away_mode and visitors can be combined into a single state trigger with multiple entities. This is more concise and follows Home Assistant best practices for maintainability.
- trigger: state
entity_id:
- input_boolean.away_mode
- input_boolean.visitors| - trigger: state | ||
| entity_id: | ||
| - input_boolean.away_mode | ||
| - trigger: state | ||
| entity_id: | ||
| - input_boolean.visitors |
There was a problem hiding this comment.
Similar to the previous automation, these triggers can be merged into a single state trigger to reduce redundancy.
- trigger: state
entity_id:
- input_boolean.away_mode
- input_boolean.visitors1 participant
This PR enables the visitors mode to work correctly when the house is in away mode.
Specifically, when
input_boolean.visitorsis ON:Other alarms/alerts (motion, door open) were already handling the visitors boolean and remain unchanged.
Modifications:
automations.yaml.automations.yaml.automations/away_mode.yaml.automations/visitors.mddocumentation.PR created automatically by Jules for task 15342960671121105392 started by @Giom-V