Removed DaasResult to resurface access check errors to the user#192
Open
Sanyam233 wants to merge 1 commit intoGeotab:mainfrom
Open
Removed DaasResult to resurface access check errors to the user#192Sanyam233 wants to merge 1 commit intoGeotab:mainfrom
Sanyam233 wants to merge 1 commit intoGeotab:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
+ Coverage 55.21% 55.31% +0.10%
==========================================
Files 9 9
Lines 547 546 -1
Branches 89 89
==========================================
Hits 302 302
+ Misses 223 222 -1
Partials 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@Sanyam233 Should the definition for |
Author
@aaront DaasResult is inherited by DaasGetJobStatusResult and DaasGetQueryResult. No cleanup required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.