[GPII-4195] Add 1909 and LTSC Windows 10 version to Vagrantfile

[amatas]

https://issues.gpii.net/browse/GPII-4195

This PR depends on GPII/ci-service#75. Both should be merged at the same time, otherwise the CI will fail.

[gpii-bot]

CI job failed: https://ci.gpii.net/job/gpii-app-tests/1066/

[amatas]

ok to test
, just to be sure that the server has downloaded the images properly.

@javihernandez could you take a look to the errors in the provisioning step?. You can replicate them running the following:

vagrant up 1909
vagrant winrm 1909 -c "do.ps1 -c 'npm run test:acceptance'"
vagrant destroy -f 1909

vagrant up LTSC
vagrant winrm LTSC -c "do.ps1 -c 'npm run test:acceptance'"
vagrant destroy -f LTSC

[gpii-bot]

CI job failed: https://ci.gpii.net/job/gpii-app-tests/1067/

[javihernandez]

ok to test

[javihernandez]

ok to test

I was having exactly the same errors on Friday, I checked choco packages, env variables, build tools, etc ... couldn't find anything suspicious.
Mysteriously, it works today, I bet it's a faulty dep update of one of our dependencies, it has happened in the past (very rare) and it's been fixed a few hours later.

Let's see how it goes on CI today.

[gpii-bot]

CI job failed: https://ci.gpii.net/job/gpii-app-tests/1070/

[javihernandez]

CI job failed: https://ci.gpii.net/job/gpii-app-tests/1070/

Right, today we're not facing the dynamic link library problem, building right both on 1909 and LTSC, see:

LTSC: Build succeeded.
    LTSC:     0 Warning(s)
    LTSC:     0 Error(s)
    LTSC: Time Elapsed 00:00:00.92
    LTSC: VERBOSE: 'C:\Windows\Microsoft.NET\Framework\v4.0.30319\msbuild.exe' exited with 0
    LTSC: VERBOSE: 'npm' exited with 0

and

1909: Build succeeded.
    1909:     0 Warning(s)
    1909:     0 Error(s)
    1909: Time Elapsed 00:00:00.95
    1909: VERBOSE: 'C:\Windows\Microsoft.NET\Framework\v4.0.30319\msbuild.exe' exited with 0
    1909: VERBOSE: 'npm' exited with 0

Errors on code analysis and tests are expected:

This command requires a specific VM name to target in a multi-VM environment.
Build step 'Execute shell' marked build as failure
Sending e-mails to: ci@lists.gpii.net
Finished: FAILURE

And should disappear after GPII/ci-service#75 is merged

[gpii-bot]

CI job failed: https://ci.gpii.net/job/gpii-app-tests/1071/

[javihernandez]

I've been running the tests and so far, they pass as expected.

• Eveything passing fine on 1909 see the test results
• We have a problem when running the tests on LTSC, and this is due to a an update that had to happen when we did the switch to 1909 - Here the actual test results and here the test results with that change reverted

So far, LGTM

[gpii-bot]

CI job failed: https://ci.gpii.net/job/gpii-app-tests/1088/

[gpii-bot]

CI job failed: https://ci.gpii.net/job/gpii-app-tests/1089/

[amatas]

ok to test

[gpii-bot]

CI job failed: https://ci.gpii.net/job/gpii-app-tests/1090/