[GT-183] Apply code styles for the files #461#483
Open
Conversation
Contributor
Author
|
Ready to be reviewed for the code issues |
Sae126V
force-pushed
the
GT-183-styles-Need-non-admin-Service-Types-views
branch
from
72ae593 to
226a495
Compare
Comment on lines
+24
to
+25
| require_once __DIR__ | ||
| . '/../../../web_portal/components/Get_User_Principle.php'; |
Member
There was a problem hiding this comment.
Is it possible to use parentheses around __DIR__ . '/../../../web_portal/components/Get_User_Principle.php' to make it clear this is the same argument to require_once.
(Note, I am not a PHP expert! I don't know if that is a good idea or not!)
Comment on lines
+12
to
+19
| <a | ||
| href="index.php?Page_Type=Admin_Edit_Service_Type&id=<?php | ||
| echo $params['ID']; | ||
| ?>" | ||
| > | ||
| Click here</a>to edit the <?php | ||
| xecho($params['Name']); | ||
| ?> service type again. |
Member
There was a problem hiding this comment.
This feels a bit too broken up and harder to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied code styles for the files touched in #461 .
Applied:
- If it is the single statement in the block (Not provided a blank line).
- In any other case always provided a blank line before it.