GT-124 Make references to operational tools configurable#412
GT-124 Make references to operational tools configurable#412
Conversation
rowan04
commented
Dec 19, 2022
- added config options for helpdesk link, helpdesk support unit, request tracker and community documentation
- so that different instances of gocdb can have links point directly to their tooling, instead of having general references
- added config options for helpdesk link, helpdesk support unit, request tracker and community documentation - so that different instances of gocdb can have links point directly to their tooling, instead of having general references
- shortened variable name - fixed href formatting - still doen't work as planned - needs a php file rework - this commit was made as I'm about to leave for christmas
- in order to have configurable links in Help_And_Contact, - the file had to be changed from .html to .php - so it was also moved to the static_php directory - the operationalLinks file was made to call the config file and assign to variables - this file is then called in Help_And_Contact
- as Help_And_Contact page was moved from a .html file to .php, - the methods that display it on the gocdb web needed to be changed - as it is no longer a static_html file
|
Note - this currently doesn't work and the gocdb webpage doesn't have the correct links. I am still working on this |
- changed method of ouputting the Help_And_Contact.php file - so it now outputs the executed file, not the file contents - meaning the php parts within the html are properly executed, and not just output
- removes unnecessary commented out code - adds to existing comments - fixes out of date code in search_ses.php
|
Hmmmmm, I wonder if moving the Help_And_Contact to be fully within the view/controller setup would be a cleaner solution than using my_sites.php is a relatively small example of the view/controller setup in use:
So for this, you'd have to create, for example:
The controller is where the code in htdocs/web_portal/static_php/operationalLinks.php would go, except with the output contained in a The view is where the contents of You'd have to add an additonal case for PageType=Help_And_Contact in web_portal/index.php, similar to the My_Sites case, but it would mean less new code in index.php. Could you give that a go? |
ok |
…ad of a static_php setup - moved static_php/Help_And_Contact.php to views/help_and_contact.php - removed static_php/operationalLinks and replaced it with controllers/help_and_contact.php - this was done so that there wasn't lots of new code for the static_php method in index.php
…and_contact.php - change to menu.xml so that it uses correct index.php case - change index.php case to use the new view/controller setup - change search_ses.php to use the correct new link
- adds missed \ in search_ses.php
gregcorbett
left a comment
There was a problem hiding this comment.
This looks great :). I want to prepare the necassary config change, in a sandbox, at the same time I merge this.