Skip to content

Feature/30 disagg rlz#157

Open
chrisdicaprio wants to merge 15 commits intomainfrom
feature/30-disagg-rlz
Open

Feature/30 disagg rlz#157
chrisdicaprio wants to merge 15 commits intomainfrom
feature/30-disagg-rlz

Conversation

@chrisdicaprio
Copy link
Copy Markdown
Collaborator

@chrisdicaprio chrisdicaprio commented Apr 21, 2026

Closes #30 and (redundant) #136

The version has not been bumped, as I thought a bump to 2.0.0 when #31, #137 (disagg aggs) would be better than 2 smaller releases

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 70.41667% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.98%. Comparing base (5bc6e58) to head (de2c012).

Files with missing lines Patch % Lines
toshi_hazard_store/scripts/ths_disagg_import.py 58.46% 26 Missing and 1 partial ⚠️
toshi_hazard_store/scripts/_common.py 58.33% 24 Missing and 1 partial ⚠️
toshi_hazard_store/oq_import/toshi_api_subtask.py 21.42% 10 Missing and 1 partial ⚠️
...zard_store/model/revision_4/extract_disagg_hdf5.py 90.14% 3 Missing and 4 partials ⚠️
toshi_hazard_store/scripts/ths_rlz_import.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
+ Coverage   68.07%   68.98%   +0.90%     
==========================================
  Files          41       45       +4     
  Lines        1920     2102     +182     
  Branches      178      196      +18     
==========================================
+ Hits         1307     1450     +143     
- Misses        601      633      +32     
- Partials       12       19       +7     
Flag Coverage Δ
unittests 68.98% <70.41%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chrisdicaprio chrisdicaprio requested review from chrisbc and voj April 23, 2026 19:24
@chrisdicaprio chrisdicaprio marked this pull request as ready for review April 23, 2026 19:24
Copy link
Copy Markdown
Collaborator

@voj voj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I also don't understand what's going on 😅

Comment thread docs/usage.md
Comment thread tests/model/pyarrow/test_disagg_reshape.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: store disaggregation realizations

2 participants