allow un-registered branch realizations#156
Merged
chrisdicaprio merged 12 commits intomainfrom Apr 13, 2026
Merged
Conversation
…to be used why querying realizations
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 67.45% 68.07% +0.62%
==========================================
Files 41 41
Lines 1914 1920 +6
Branches 179 178 -1
==========================================
+ Hits 1291 1307 +16
+ Misses 612 601 -11
- Partials 11 12 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chrisbc
approved these changes
Apr 13, 2026
Member
chrisbc
left a comment
There was a problem hiding this comment.
@chrisdicaprio all good but the one question re CodedLocation usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All reading of realization data (e.g. by toshi-hazard-post) is done ad-hoc via pyarrow as there is no toshi-hazad-store API for querying the realization data. A helper function has been provided to check if requested branches are un-registered and warn if so. This can be used by any user of the dataset or included in a future query API.