Skip to content

Proper stream parsing in glvis-js#340

Merged
tzanio merged 21 commits intomasterfrom
time-series-js
Feb 5, 2026
Merged

Proper stream parsing in glvis-js#340
tzanio merged 21 commits intomasterfrom
time-series-js

Conversation

@najlkin
Copy link
Contributor

@najlkin najlkin commented May 31, 2025

This PR unifies handling of streams in JS and glvis app to enable all stream commands, resolving #315. Moreover, it introduces animations, i.e., time series of solutions.

⭐ bonus:

  • Fixed compilation with emscripten on Mac to not use CGL

↪️ dependencies:

@najlkin najlkin linked an issue May 31, 2025 that may be closed by this pull request
@tzanio tzanio mentioned this pull request Jan 5, 2026
42 tasks
@najlkin najlkin added this to the glvis-4.5 milestone Jan 29, 2026
@najlkin najlkin changed the base branch from master to egl-headless January 29, 2026 22:31
@najlkin najlkin changed the title [WIP] Proper stream parsing and animations in glvis-js [WIP] Proper stream parsing in glvis-js Jan 29, 2026
@najlkin najlkin changed the title [WIP] Proper stream parsing in glvis-js Proper stream parsing in glvis-js Jan 30, 2026
@najlkin najlkin removed the WIP label Jan 30, 2026
@najlkin
Copy link
Contributor Author

najlkin commented Jan 30, 2026

To be clear, this PR enables general processing, but we cannot distinguish between files and streams in aux_js.cpp, where waiting for the latter would stop the visualization. The method display() just simply executes all commands from the stream as it worked so far, which does not allow animations really. It would be easy to extend, but it requires changes on the side of glvis-js.

Base automatically changed from egl-headless to master January 31, 2026 03:56
@najlkin
Copy link
Contributor Author

najlkin commented Jan 31, 2026

This is glvis-js compilation with the latest commit: https://github.com/GLVis/glvis-js/actions/runs/21537548572 (branch ci-build-21537548572). Please test if everything works as intended in glvis-js 👈

@tzanio
Copy link
Member

tzanio commented Feb 2, 2026

@najlkin can you resolve conflict?

Also, should this be mentioned in CHANGELOG?

@najlkin
Copy link
Contributor Author

najlkin commented Feb 2, 2026

Done 👍 The latest compilation of glvis-js: https://github.com/GLVis/glvis-js/actions/runs/21602577550 (branch ci-build-21602577550). Please test if everything works as intended in glvis-js 👈

@tzanio tzanio self-requested a review February 3, 2026 19:12
@najlkin
Copy link
Contributor Author

najlkin commented Feb 3, 2026

I just managed to make running and test glvis-live and it works perfectly, actually better than master, which does not load correctly the new test/example ex6-dofs-numbering.saved (due to unsupported commands) 👍 .

@justinlaughlin
Copy link
Contributor

Tested and it looks good to me!

Copy link
Member

@tzanio tzanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tested and looks look good, thanks @najlkin !

@tzanio tzanio merged commit dc73e79 into master Feb 5, 2026
10 checks passed
@tzanio tzanio deleted the time-series-js branch February 5, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stream commands unavailable in glvis-js

4 participants