[ENHANCEMENT] Strumline background no longer overlaps other UI elements.#7233
Open
Starexify wants to merge 1 commit intoFunkinCrew:developfrom
Open
[ENHANCEMENT] Strumline background no longer overlaps other UI elements.#7233Starexify wants to merge 1 commit intoFunkinCrew:developfrom
Starexify wants to merge 1 commit intoFunkinCrew:developfrom
Conversation
github-actions
bot
added
pr: haxe
Starexify
force-pushed
the
fix-strumline-bg
branch
from
75621aa to
03aff47
Compare
|
Oh fuck yes this actually looks really good and solves my main complaint of the strumline going over one of the opponent notes on mobile |
Hundrec
added
type: minor bug
3 tasks
Hundrec
added
the
topic: changes assets
Starexify
force-pushed
the
fix-strumline-bg
branch
from
03aff47 to
b6eee74
Compare
github-actions
bot
added
size: large
Starexify
force-pushed
the
fix-strumline-bg
branch
from
b6eee74 to
8eb8a40
Compare
Starexify
force-pushed
the
fix-strumline-bg
branch
from
8eb8a40 to
edf12f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Description
This PR changes the strumline background to allow UI elements to show above it and no longer layer over them.
Important
Requires PR to fix the strumline hiding in assets: FunkinCrew/funkin.assets#398
Screenshots/Videos
Desktop
Mobile
About offsets/lag adjustement substate, not sure if the background should show as before or not, same goes for minimal playstate