Skip to content

[BUGFIX] Fix alignment for Pixel icons in Editor character selectors#7185

Open
Starexify wants to merge 1 commit intoFunkinCrew:developfrom
Starexify:fix-charteditor-pixel-icon-offsets
Open

[BUGFIX] Fix alignment for Pixel icons in Editor character selectors#7185
Starexify wants to merge 1 commit intoFunkinCrew:developfrom
Starexify:fix-charteditor-pixel-icon-offsets

Conversation

@Starexify
Copy link
Copy Markdown
Contributor

@Starexify Starexify commented Mar 19, 2026

Linked Issues

Description

This PR removes the idleFrame offsets from the pixel icons in the Chart and Stage Editor character selector lists.

Screenshots/Videos

Didn't make videos of Stage Editor but I checked and it's the same fix there aswell.

0.8.3 (develop)

Old.Chart.Editor.webm

This PR

Fixed.Chart.Editor.webm

@github-actions github-actions bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. size: tiny A tiny pull request with 4 or fewer changes. and removed status: pending triage Awaiting review. labels Mar 19, 2026
@Starexify Starexify force-pushed the fix-charteditor-pixel-icon-offsets branch from ab9ae2c to 765008e Compare March 19, 2026 23:29
@Hundrec Hundrec changed the title [FIX] Pixel icons in Chart/Stage Editor character selectors alignment being off-centered. [BUGFIX] Fix alignment for Pixel icons in Editor character selectors Mar 19, 2026
@Hundrec Hundrec added type: minor bug Involves a minor bug or issue. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. labels Mar 19, 2026
Hundrec
Hundrec requested changes Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Image

@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Mar 20, 2026
@Starexify Starexify force-pushed the fix-charteditor-pixel-icon-offsets branch from 765008e to cfa0a10 Compare March 20, 2026 16:22
@Starexify
Copy link
Copy Markdown
Contributor Author

Starexify commented Mar 20, 2026

lol

I didn't encounter this issue when testing this, so it's not from my PR, unless you don't use the develop branch
image

@Hundrec
Copy link
Copy Markdown
Member

Hundrec commented Mar 20, 2026

Did a quick test and it indeed doesn't happen on develop
Might be something behaving differently internally, I'll have to check it out after 0.8.4 release

@Hundrec Hundrec added status: pending triage Awaiting review. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Mar 20, 2026
@Hundrec Hundrec self-requested a review March 20, 2026 22:38
@Starexify
Copy link
Copy Markdown
Contributor Author

Starexify commented Mar 25, 2026

same here the issue isnt linked 😬

@Hundrec Hundrec linked an issue Mar 26, 2026 that may be closed by this pull request
Bug Report: Kazuha icon is offset in Chart Editor #7173
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hundrec Hundrec Awaiting requested review from Hundrec

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: tiny A tiny pull request with 4 or fewer changes. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug Report: Kazuha icon is offset in Chart Editor

2 participants

@Starexify @Hundrec