Actually using the new product_query#344
Draft
beojan wants to merge 23 commits intoFramework-R-D:mainfrom
Draft
Conversation
Won't build yet
This handles the API change, and ports the existing creator name check to work with the new product_query.
Also use std::unreachable() instead of kind = "HOW??"s;
- Introduce `identifier` - Combine `product_query` and `product_tag` - Express above in terms of `identifier` - Changes to make everything work again
Mostly compilation errors, plus exception change in configuration test
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (72.03%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #344 +/- ##
==========================================
+ Coverage 82.26% 83.60% +1.33%
==========================================
Files 127 120 -7
Lines 3102 2336 -766
Branches 547 392 -155
==========================================
- Hits 2552 1953 -599
+ Misses 333 248 -85
+ Partials 217 135 -82
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.