Skip to content

Remove unneeded peers#248

Merged
mkszepp merged 1 commit into3.xfrom
drop-tracking-ember-source-peer
May 10, 2025
Merged

Remove unneeded peers#248
mkszepp merged 1 commit into3.xfrom
drop-tracking-ember-source-peer

Conversation

@mkszepp
Copy link
Copy Markdown
Collaborator

@mkszepp mkszepp commented May 10, 2025

  • ember-source: removed because the embroider / auto-import know what we intend - it's not bad to have if someone manages their dep graph correctly, which is easier with pnpm, but not everyone gets it right, and folks have a hard time tracking down errors
  • @glimmer/tracking removed because it's a real package, but one we don't want to use. This comes up in embroider/vite where the presence of real packages always takes precedence over virtual packages. This is actually problematic because it can break reactivity in subtle ways, even if a dep graph is correct - allowing duplicates of dependencies, which for the glimmer internals, we don't want.

ref ember-cli/ember-addon-blueprint#35

@mkszepp mkszepp merged commit 20cb4aa into 3.x May 10, 2025
16 checks passed
@mkszepp mkszepp deleted the drop-tracking-ember-source-peer branch May 10, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant