fix: fixed the logic for scroll event on zoom-voronoi container#3060
Open
Dharmesh-Kota wants to merge 1 commit intoFormidableLabs:mainfrom
Open
fix: fixed the logic for scroll event on zoom-voronoi container#3060Dharmesh-Kota wants to merge 1 commit intoFormidableLabs:mainfrom
Dharmesh-Kota wants to merge 1 commit intoFormidableLabs:mainfrom
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary:
This change updates the default
eventHandlersinVictoryZoomContainer.defaultEventsso that theonWheelhandler is only attached whenprops.allowZoomis true. Previously, theonWheelhandler was always registered (but disabled via the handler’sdisabledflag), which could still trigger unnecessary event binding and potential side effects.Fixes:
Prevents
onWheelfrom being registered whenallowZoomis false.Motivation and Context:
VictoryZoomContainer.props.allowZoominside the handler body for wheel events.Dependencies:
defaultEventsconfiguration invictory-zoom-container.jsand does not introduce new dependencies.Fixes # (issue)
Type of Change