Conversation
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=======================================
Coverage 98.41% 98.41%
=======================================
Files 19 19
Lines 253 253
=======================================
Hits 249 249
Misses 4 4Continue to review full report at Codecov.
|
|
This ordering is a bit weird IMHO. My colleague Roy agrees. |
|
The point is to explain that the order of the routes matters and that redux-little-router uses a simple routing scheme where the order of the
If you think this will be obvious to everyone using this library, then I guess it's not worth adding it to the README. The code snippet is meant to be an example of what not to do. Perhaps that is not clear enough. |
|
There is nothing wrong with this PR, it's actually very good to have it documented if that's the expected behaviour. However, I think we should change the library to accept routes in the correct order, instead of documenting what for me is almost a bug. Thanks for creating the PR though! I wish this was documented before I struggled trying to understand why my routes wasn't working. |
Documents the fact that the order in which Fragments are declared matters.
Updates a small detail in another Fragments example the README to improve readability.