Open
Conversation
If the transport has been previously connected, the isSecure flag may still be set from a previous connection. This can lead to not negotiating TLS on the new connection. In practice this caused a stream error, because the post-TLS stream reset was still sent unconditionally. This change makes reconnecting a transport negotiate TLS successfully.
closeChan is used to communicate that a stream close has been received. In the case where the client initiates the stream closure, this works: 1) client sends stream close 2) client reads from closeChan, waiting for the server's stream close In the case where the server initiates the stream closure, it failed: 1) transport writes to closeChan x) client is not waiting on closeChan, so the write blocks and transport hangs This change allows up to one event to be written asynchronously to closeChan. After the client is notified about the disconnection, it will read from closeChan as in the client-initiated flow but will simply find the stream close already there.
|
@mremond: Have you seen this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes multiple small fixes go-xmpp to successfully reconnect when the server sends a
</stream:stream>.