feat(deploy): add SDK service to ECS deployment pipeline #6484
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add deployment of flagsmith-sdk ECS service alongside the main API service. Both services share the same task definition family (flagsmith-api) and are deployed sequentially. Changes: - Add aws_ecs_sdk_service_name input to api-deploy-ecs action - Add SDK service deployment step using same task definition - Update wait step to wait for both services to stabilize - Pass new input from reusable workflow Requires adding AWS_ECS_SDK_SERVICE_NAME environment variable to staging and production GitHub environments.
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on January 10. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Contributor
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6484 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 1294 1294
Lines 46537 46537
=======================================
Hits 45639 45639
Misses 898 898 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
khvn26
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Add deployment of SDK ECS service alongside the main API service. Both services share the same task definition family (
flagsmith-api) and are deployed sequentially.aws_ecs_sdk_service_nameinput toapi-deploy-ecsactionManual Steps Required (Post-Merge):
Configure GitHub Environment Variables in repository settings:
AWS_ECS_SDK_SERVICE_NAMEto the appropriate valueAWS_ECS_SDK_SERVICE_NAMEto the appropriate valueHow did you test this code?