Skip to content

fix: Pin firefox version#6244

Merged
matthewelwell merged 5 commits intomainfrom
fix/e2e-firefox
Nov 5, 2025
Merged

fix: Pin firefox version#6244
matthewelwell merged 5 commits intomainfrom
fix/e2e-firefox

Conversation

@kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Nov 4, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Pins Firefox to 143.0, 144.0 has a breaking change with TestCafe which is breaking our e2e whereby none of the tests appear to run. Here's an example where tests have started hanging https://github.com/Flagsmith/flagsmith/actions/runs/19045462728/job/54392661526#step:6:937.

This PR also adds a workflow_dispatch trigger to the workflow which builds the E2E base image, since we had to temporarily add a push trigger in this PR (see here). Having a workflow dispatch would have negated the need for this so it's been added here for any future needs.

Possibly related: DevExpress/testcafe#8452

How did you test this code?

Passing E2E tests on this PR (e.g. https://github.com/Flagsmith/flagsmith/actions/runs/19086275598/job/54527223362?pr=6244)

@kyle-ssg kyle-ssg requested a review from a team as a code owner November 4, 2025 22:50
@kyle-ssg kyle-ssg requested review from Zaimwa9 and removed request for a team November 4, 2025 22:50
@vercel
Copy link

vercel bot commented Nov 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs Ignored Ignored Preview Nov 4, 2025 11:39pm
flagsmith-frontend-preview Ignored Ignored Preview Nov 4, 2025 11:39pm
flagsmith-frontend-staging Ignored Ignored Preview Nov 4, 2025 11:39pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Nov 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6244 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6244 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-6244 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-6244 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6244 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6244 Finished ✅ Results

@kyle-ssg kyle-ssg requested review from khvn26 and removed request for Zaimwa9 November 4, 2025 23:05
@github-actions github-actions bot added fix and removed fix labels Nov 4, 2025
@github-actions github-actions bot added fix and removed fix labels Nov 4, 2025
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.01%. Comparing base (fca1318) to head (c5d5022).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6244   +/-   ##
=======================================
  Coverage   98.01%   98.01%           
=======================================
  Files        1278     1278           
  Lines       45178    45178           
=======================================
  Hits        44280    44280           
  Misses        898      898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthewelwell matthewelwell marked this pull request as ready for review November 4, 2025 23:28
@matthewelwell matthewelwell requested a review from a team as a code owner November 4, 2025 23:28
@github-actions github-actions bot added fix and removed fix labels Nov 4, 2025
@github-actions github-actions bot removed the fix label Nov 4, 2025
@github-actions github-actions bot added the fix label Nov 4, 2025
Copy link
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@matthewelwell matthewelwell merged commit 3f8b260 into main Nov 5, 2025
32 checks passed
@matthewelwell matthewelwell deleted the fix/e2e-firefox branch November 5, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants