Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Contributor
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6244 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 1278 1278
Lines 45178 45178
=======================================
Hits 44280 44280
Misses 898 898 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kyle-ssg
commented
Nov 4, 2025
matthewelwell
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Pins Firefox to 143.0, 144.0 has a breaking change with TestCafe which is breaking our e2e whereby none of the tests appear to run. Here's an example where tests have started hanging https://github.com/Flagsmith/flagsmith/actions/runs/19045462728/job/54392661526#step:6:937.
This PR also adds a
workflow_dispatchtrigger to the workflow which builds the E2E base image, since we had to temporarily add a push trigger in this PR (see here). Having a workflow dispatch would have negated the need for this so it's been added here for any future needs.Possibly related: DevExpress/testcafe#8452
How did you test this code?
Passing E2E tests on this PR (e.g. https://github.com/Flagsmith/flagsmith/actions/runs/19086275598/job/54527223362?pr=6244)