Skip to content

deps: bump dj-database-url from v0.5.0 to v3.0.1, add django_cockroachdb#5789

Merged
khvn26 merged 3 commits intoFlagsmith:mainfrom
scarlson:support-cockroachdb
Jul 23, 2025
Merged

deps: bump dj-database-url from v0.5.0 to v3.0.1, add django_cockroachdb#5789
khvn26 merged 3 commits intoFlagsmith:mainfrom
scarlson:support-cockroachdb

Conversation

@scarlson
Copy link
Contributor

@scarlson scarlson commented Jul 18, 2025

… for cockroach support

Issue: #5781

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • dependency dj-database-url upgrade from v0.5.0 to v3.0.1 for additional db support
  • dependency django_cockroachdb added to enable CockroachDB support for Django.

How did you test this code?

New API image was generated with the changes. API image was deployed with external database pointing to CockroachDB v21.2.17.

@scarlson scarlson requested review from a team as code owners July 18, 2025 19:21
@scarlson scarlson requested review from gagantrivedi and removed request for a team July 18, 2025 19:21
@vercel
Copy link

vercel bot commented Jul 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 1:11pm

@vercel
Copy link

vercel bot commented Jul 18, 2025

@scarlson is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added api Issue related to the REST API docs Documentation updates labels Jul 18, 2025
@khvn26
Copy link
Member

khvn26 commented Jul 19, 2025

Hi @scarlson ! Thanks for your contribution. Can you fix the typing errors?

@scarlson
Copy link
Contributor Author

scarlson commented Jul 19, 2025

Hi @scarlson ! Thanks for your contribution. Can you fix the typing errors?

@khvn26
The typing errors are on main and unrelated to my change. Happy to rebase once resolved.

User error, poetry lock had 3.0.1 when I tested main. Latest commit addresses typecheck failures.

git status
On branch main
Your branch is up to date with 'origin/main'.

python --version
Python 3.11.12

flagsmith/api git:(main) > make typecheck
poetry run mypy .
/Users/scarlson/code/flagsmith/api/app/settings/common.py:19: error: Unused "type: ignore" comment  [unused-ignore]
/Users/scarlson/code/flagsmith/api/app/settings/common.py:179: error: Argument "conn_max_age" to "parse" has incompatible type "int | None"; expected "int"  [arg-type]
HEAD is now at 83ddbca6 chore(main): release 2.187.0 (#5691)
➜  api git:(v2.187.0) git status
HEAD detached at upstream/main
nothing to commit, working tree clean
➜  api git:(v2.187.0) make typecheck
poetry run mypy .
/Users/scarlson/code/flagsmith/api/app/settings/common.py:19: error: Unused "type: ignore" comment  [unused-ignore]
/Users/scarlson/code/flagsmith/api/app/settings/common.py:179: error: Argument "conn_max_age" to "parse" has incompatible type "int | None"; expected "int"  [arg-type]

@khvn26
Copy link
Member

khvn26 commented Jul 20, 2025

@scarlson The main branch does not produce typing errors. They are introduced by the dependency bump.

@scarlson scarlson force-pushed the support-cockroachdb branch from 4cc23df to eea29b5 Compare July 21, 2025 16:53
@scarlson scarlson changed the title chore(api): update dj-database-url dependency, add django_cockroachdb… deps(api): update dj-database-url dependency, add django_cockroachdb… Jul 21, 2025
@scarlson
Copy link
Contributor Author

@scarlson The main branch does not produce typing errors. They are introduced by the dependency bump.

You were right. Mea culpa. Poetry lock had 3.0.1 when I was testing main.

make typecheck comes back clean on local now.

@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.82%. Comparing base (1e4c2e1) to head (cf8f3dd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5789   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files        1257     1257           
  Lines       44700    44700           
=======================================
  Hits        43726    43726           
  Misses        974      974           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall with a tiny comment on the docs change.

…Postgres as the only officially tested and supported db.
khvn26
khvn26 previously approved these changes Jul 21, 2025
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@khvn26 khvn26 changed the title deps(api): update dj-database-url dependency, add django_cockroachdb… deps: bump dj-database-url from v0.5.0 to v3.0.1, add django_cockroachdb Jul 23, 2025
@khvn26 khvn26 self-requested a review July 23, 2025 13:12
@khvn26 khvn26 merged commit 70d4b59 into Flagsmith:main Jul 23, 2025
15 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API docs Documentation updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants