deps: bump dj-database-url from v0.5.0 to v3.0.1, add django_cockroachdb#5789
deps: bump dj-database-url from v0.5.0 to v3.0.1, add django_cockroachdb#5789khvn26 merged 3 commits intoFlagsmith:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@scarlson is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @scarlson ! Thanks for your contribution. Can you fix the typing errors? |
@khvn26 User error, poetry lock had 3.0.1 when I tested main. Latest commit addresses typecheck failures. git status
On branch main
Your branch is up to date with 'origin/main'.
python --version
Python 3.11.12
flagsmith/api git:(main) > make typecheck
poetry run mypy .
/Users/scarlson/code/flagsmith/api/app/settings/common.py:19: error: Unused "type: ignore" comment [unused-ignore]
/Users/scarlson/code/flagsmith/api/app/settings/common.py:179: error: Argument "conn_max_age" to "parse" has incompatible type "int | None"; expected "int" [arg-type]HEAD is now at 83ddbca6 chore(main): release 2.187.0 (#5691)
➜ api git:(v2.187.0) git status
HEAD detached at upstream/main
nothing to commit, working tree clean
➜ api git:(v2.187.0) make typecheck
poetry run mypy .
/Users/scarlson/code/flagsmith/api/app/settings/common.py:19: error: Unused "type: ignore" comment [unused-ignore]
/Users/scarlson/code/flagsmith/api/app/settings/common.py:179: error: Argument "conn_max_age" to "parse" has incompatible type "int | None"; expected "int" [arg-type] |
|
@scarlson The main branch does not produce typing errors. They are introduced by the dependency bump. |
…for cockroach support
4cc23df to
eea29b5
Compare
You were right. Mea culpa. Poetry lock had 3.0.1 when I was testing main.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5789 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 1257 1257
Lines 44700 44700
=======================================
Hits 43726 43726
Misses 974 974 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
khvn26
left a comment
There was a problem hiding this comment.
LGTM overall with a tiny comment on the docs change.
…Postgres as the only officially tested and supported db.
… for cockroach support
Issue: #5781
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
How did you test this code?
New API image was generated with the changes. API image was deployed with external database pointing to CockroachDB v21.2.17.