Merged
Conversation
# Conflicts: # frontend/common/utils/utils.tsx
# Conflicts: # frontend/web/styles/_variables.scss
# Conflicts: # frontend/common/types/requests.ts # frontend/common/types/responses.ts
# Conflicts: # frontend/common/types/responses.ts
# Conflicts: # frontend/common/types/requests.ts # frontend/common/types/responses.ts # frontend/common/utils/utils.tsx # frontend/web/components/pages/HomeAside.tsx # frontend/web/components/pages/HomePage.js # frontend/web/project/api.js
Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>
…come-page # Conflicts: # frontend/web/components/pages/GettingStartedPage.tsx
# Conflicts: # frontend/common/types/requests.ts
github-actions
bot
added
feature
github-actions
bot
added
feature
Zaimwa9
approved these changes
Jun 2, 2025
Contributor
Zaimwa9
left a comment
Zaimwa9
left a comment
There was a problem hiding this comment.
Couple of comments, as minor I solved them:
- Double if that could get merged
- Shrink-0 on resources icons
- Moved to /onboarding some components
- Migrated Error/success messages to typescript in
messages/XXMessagesbut only used them in TestWebhook (to test them) and OnboardingForm to not mix-up the scope. I'll create a PR migrating them just after
# Conflicts: # frontend/e2e/helpers.cafe.ts
|
Flagsmith feature linked:
|
|
Flagsmith Feature
|
|
Flagsmith Feature
|
|
Flagsmith Feature
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Upon creating an organisation or completing the onboarding flow, the user is now directed to a welcome/getting started page.
How did you test this code?