Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Contributor
Docker builds report
|
Contributor
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5407 +/- ##
==========================================
+ Coverage 97.62% 97.63% +0.01%
==========================================
Files 1238 1239 +1
Lines 43037 43065 +28
==========================================
+ Hits 42014 42046 +32
+ Misses 1023 1019 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matthewelwell
approved these changes
May 1, 2025
Contributor
matthewelwell
left a comment
There was a problem hiding this comment.
Happy for you to add # pragma: no cover where needed if it's easier than writing tests to cover the view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Previously, we were requiring users to enter an email address so that they could receive these reports:
This is not ideal for several reasons:
This change also intentionally breaks the
/sales-dashboard/email-usageroute by renaming it to/sales-dashboard/usage. It is extremely unlikely that this will actually break anyone's links, considering it's not a documented route and this route would be used ~2x a year at most.Alternatives considered
If we really want to keep emails for some reason, we could have a plain-text report be sent directly from the client, by using a
mailtolink from the same HTML-rendered report. I decided to keep HTML only for simplicity.How did you test this code?
Manually by browsing to
/sales-dashboard/usageon any API instance.