-
Notifications
You must be signed in to change notification settings - Fork 2
feat(schemas): Add SDK API request and response schemas #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 95.48% 95.67% +0.19%
==========================================
Files 83 85 +2
Lines 2767 2891 +124
==========================================
+ Hits 2642 2766 +124
Misses 125 125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b9c7f52 to
6921024
Compare
emyller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few edit suggestions. None blocking.
Co-authored-by: Evandro Myller <[email protected]>
Co-authored-by: Evandro Myller <[email protected]>
emyller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thread.
Co-authored-by: Evandro Myller <[email protected]>
Zaimwa9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions / questions 👍
Zaimwa9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Contributes to Flagsmith/flagsmith#6341.
In this PR, we add types representing the SDK API request and response bodies to be used as
The types are accompanied by docstrings carrying user-facing API documentation.