Skip to content

Conversation

@khvn26
Copy link
Member

@khvn26 khvn26 commented Jan 9, 2026

Contributes to Flagsmith/flagsmith#6341.

In this PR, we add types representing the SDK API request and response bodies to be used as

  1. source of truth when generating SDK API OpenAPI schemas.
  2. Type annotations for Flagsmith server implementations and Flagsmih client code written in Python.

The types are accompanied by docstrings carrying user-facing API documentation.

@khvn26 khvn26 requested a review from a team as a code owner January 9, 2026 12:14
@khvn26 khvn26 requested review from emyller and removed request for a team January 9, 2026 12:14
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.67%. Comparing base (94154b0) to head (d3c90b4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   95.48%   95.67%   +0.19%     
==========================================
  Files          83       85       +2     
  Lines        2767     2891     +124     
==========================================
+ Hits         2642     2766     +124     
  Misses        125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few edit suggestions. None blocking.

Copy link
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thread.

Co-authored-by: Evandro Myller <[email protected]>
@khvn26 khvn26 requested a review from emyller January 13, 2026 11:21
emyller
emyller previously approved these changes Jan 13, 2026
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions / questions 👍

@khvn26 khvn26 requested review from Zaimwa9 and emyller January 13, 2026 16:38
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@khvn26 khvn26 merged commit 65870a7 into main Jan 14, 2026
3 checks passed
@emyller emyller deleted the feat/api-schemas branch January 14, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants