Skip to content

Singleton safe getter #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rascar-capac wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Singleton safe getter #119

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd73ecf
Remove region comments
rascar-capac Jun 18, 2024
08325ae
Put static field above
rascar-capac Jun 18, 2024
796dc89
Add Singleton.TryGetInstance
rascar-capac Jun 18, 2024
1337499
Improve log when 2 singletons detected + make it a warning
rascar-capac Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions Runtime/Singleton.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,9 @@ namespace FishingCactus.CommonCode
public class Singleton<_INSTANCE_> : MonoBehaviour
where _INSTANCE_ : Singleton<_INSTANCE_>
{
// -- FIELDS

[SerializeField] private bool DestroyOnLoad = false;

private static _INSTANCE_ _instance = null;

// -- PROPERTIES
[SerializeField] private bool DestroyOnLoad = false;

public static _INSTANCE_ Instance
{
Expand All @@ -28,7 +24,12 @@ public static _INSTANCE_ Instance

public static bool HasInstance => _instance != null;

// -- UNITY
public static bool TryGetInstance( out _INSTANCE_ instance )
{
instance = Instance;

return instance != null;
}

public virtual void Awake()
{
Expand All @@ -43,10 +44,10 @@ public virtual void Awake()
}
else if( _instance != this )
{
Debug.LogError( $"{_instance.name} is added two times.", this );
Debug.LogWarning( $"There are two instances of {_instance.name}. The latest one will be destroyed.", _instance );

Destroy( this );
}
}
}
}
}