Showing Smart Window chat on History fullscreen#114
Open
unifolia wants to merge 2 commits intosmart-windowfrom
Open
Showing Smart Window chat on History fullscreen#114unifolia wants to merge 2 commits intosmart-windowfrom
unifolia wants to merge 2 commits intosmart-windowfrom
Conversation
Collaborator
Author
|
Actually - decided to remove History-specific attribute. Are there any instances of full screen (excluding video) by which we DON'T want the chat to show? The History attr probably useful for the future but will leave without until definitively required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hooked new smart-window-history attr into render method to delineate History page, ensuring that Smart Window chat exists in History fullscreen