Draft
Conversation
added 3 commits
December 24, 2021 16:12
Replace json.Unmarshal with json.NewDecoder.
This reverts commit 4b66aa7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Replace io.ReadAll + json.Unmarhal with json.NewDecoder
Added new SearchTyped method to serialize hits to user defined type instead of intermediate map[string]interface{}
What problem is this fixing?
Reducing memory allocations
Typed - version with typed response and json decoder
NonTyped - version with json decoder
NonTypedRA - version with io.ReadAll + json.Unmarshal