WIP: Payments contract should compile without via-ir being set to true in foundry.toml#149
Draft
pali101 wants to merge 2 commits intoFilOzone:mainfrom
Draft
WIP: Payments contract should compile without via-ir being set to true in foundry.toml#149pali101 wants to merge 2 commits intoFilOzone:mainfrom
pali101 wants to merge 2 commits intoFilOzone:mainfrom
Conversation
- refactor internal settlement logic to use SettlementResult and SettlementState structs for cleaner return handling and avoiding stack-too-deep error. - replace depositWithPermit() multi-argument signature with a PermitParams struct. - move arbitration logic out of _settleSegment() into dedicated _runArbitration() helper. - split modifyRailPayment logic into internal _modifyRailPayment. - minor grouping, naming, and internal structure improvements.
pali101
changed the title
Contributor
|
@pali101 Let's get back to this after the M2 milestone. Thanks for your hard work so far. |
Contributor
|
@wjmelements : is this still worth doing, or should we close this? |
Collaborator
|
Bummer! This would have been great. |
Collaborator
|
We don't plan to redeploy Payments so let's close |
Contributor
|
Ack, ok. I'll put this back into todo, so it's there for consideration if we do a filecoin-pay update. If it looks like that isn't going to happen in 2026 then we'll close these open draft PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the Payments contract to reduce call stack depth and remove the requirement for
via-irinfoundry.toml.Breaking Changes
To address stack depth limits, I had to change function signatures of few external/public function (e.g.,
settleRail,settleTerminatedRailWithoutArbitrationetc). Key changes:PermitParams).Remaining work
Update tests to use the new function signatures and verify full functionality.