Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
silent-cipher
left a comment
There was a problem hiding this comment.
Looks good overall, but I have a concern around deployment support.
Goldsky doesn’t currently support trace_filter on calibration, and the fix on mainnet hasn’t landed yet. Since subgraph indexing fails when call handlers are enabled without full RPC support, how are we planning to move forward here? I don’t think we can safely merge this until call handlers are fully supported.
Apparently fix has been landed to lotus and the RPC providers have been updated It might be good to deploy this subgraph independently to test the changes first before merging so we make sure that fix indeed works. |
|
Based on our discussion with Goldsky, call handlers aren’t supported on calibration. Even after the fix, they’ll only be enabled on mainnet. |
@silent-cipher based on the conversation with the Goldsky team the traces have been enabled for the calibration network.
|
|
I tried deploying the subgraph from this branch on both networks, but it fails to index with errors. This suggests that traces haven’t been fully enabled by Goldsky yet - |
… feat/collect-auction-stats
|
@silent-cipher @rjan90 : what's the latest here? Are we unblocked now? |
|
Latest here is that Glif was running an older version of Lotus on Mainnet. They said they would update to the Lotus v1.35.0 release yesterday. Following up with them here |
|
The private endpoints Goldsky was using from Protofire is now returning the correct They are also using |
|
@silent-cipher would you be able to redeploy the subgraph with the features added in the PR? |
|
I’ve redeployed the subgraph on mainnet with the changes from the PR. However, it seems to be stuck, and I’m seeing the following debug logs: |
Separate issue, but this seems like a bug that we need to ask an individual developer to redeploy a subragph (I assume through the Goldsky UI). How hard would it be to have a gitops deployment pipeline? |
It’s actually not very hard to set up a GitOps deployment pipeline. Goldsky already provides a gh action to deploy the subgraph. The bigger consideration is the release strategy. Since the ui depends on the subgraph url (configured via vercel env), we’d need to:
So gitops is doable. We just need to carefully design the sequencing to avoid breaking production during sync time. |
Did it got unstuck by any chance? Could the Goldsky be the issue again? |
|
I'm following up with Goldsky on this |
|
This is being investigated on the Goldsky & FilOz side |

Adds call handlers for
burnForFeesmethod and fixes fee handling for settlements and one-time payments.Closes #70
TODO