Open
Conversation
Make Penetration work when explosions dealing damage on characters Removed hard-coded StructureDamage limit
Author
|
Will fix #16939 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Changes]
Made penetration work when dealing damage on characters
Removed 1800 (600*3) distance hard-coded limit for structureDamage
[Reasons]
I noticed multiple explosives have penetration parameter but penetration were never used during the whole process
There are explosions with range over 1800 in mods
The hard limit seems no use because there is only one enumeration operation and it is on WallList in the affacted codes and the return value was only used when playing sounds
[Tests]
Part.1 structureDamage range test
Release Ver: The damage is limited to near ~1800 marker
PR Ver: The damage goes further than ~4000 marker
Part.2 penetration test
2x Timed detonator
1x [DebugOnlyTest]C4WithoutPen
1x [DebugOnlyTest]C4WithPen
1x [DebugOnlyTest]EXPLOSIONTESTSUIT
Release Ver + PR Ver: No damage to the character
Release Ver: No damage to the character
PR Ver: Character was damaged
[Notes]