Add method hierarchy propagation via MIO and Hypo#4148
Open
NebelNidas wants to merge 3 commits intoFabricMC:25w10afrom
Open
Add method hierarchy propagation via MIO and Hypo#4148NebelNidas wants to merge 3 commits intoFabricMC:25w10afrom
NebelNidas wants to merge 3 commits intoFabricMC:25w10afrom
Conversation
This acts as a replacement for the now deprecated `MapSpecializedMethodsTask`, allowing us to remove Enigma from the build process in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loosely based on modmuss50@c4b22c0.
This acts as a replacement for the now deprecated
MapSpecializedMethodsTask, allowing us to remove Enigma from the build process in the future.Hypo was chosen as the backend since Tiny Remapper doesn't expose the necessary bridge information yet, Enigma's handling is broken and Matcher is neither on Maven, nor does it index synthetic sources/targets.
Hypo on the other hand provides most of the required functionality out of the box and is battle-tested thanks to its extensive use in the PaperMC toolchain since 2021.
If you want to compare the old
yarn-specialized-mappings-v2.tinywith the newyarn-propagated-v2.tiny, I recommend pasting the following snippet intoMapSpecializedMethodsTask:Succeeds #4123, whose code was accidentally pushed to the wrong repo.