Open
Conversation
Contributor
Author
|
Is missing config from fabric cli, I would convert to a draft but there seems to be no option to do that from the GitHub mobile app. |
modmuss50
reviewed
Feb 22, 2026
Member
modmuss50
left a comment
modmuss50
left a comment
There was a problem hiding this comment.
Also update the CLI and add it to the test script here: https://github.com/FabricMC/fabricmc.net/blob/main/cli/test.ts and run the tests to make sure this works on all versions.
scripts/src/lib/template/templates/gradle/kotlin/settings.gradle.kts.eta
Show resolved
Hide resolved
scripts/src/lib/template/templates/gradle/kotlin/gradle.properties.eta
Outdated
Show resolved
Hide resolved
| <% if (it.kotlin) { %><% if (it.unobfuscated) { %>implementation<% } else { %>modImplementation<% } %>("net.fabricmc:fabric-language-kotlin:$fabricKotlinVersion")<% } %> | ||
| } | ||
|
|
||
| tasks.processResources { |
Member
There was a problem hiding this comment.
Again should be lazy, we should also adjust this in the groovy template (not as part of this PR).
Contributor
Author
There was a problem hiding this comment.
Not sure about groovy, but this is already lazy in Kotlin.
scripts/src/lib/template/templates/gradle/kotlin/build.gradle.kts.eta
Outdated
Show resolved
Hide resolved
scripts/src/lib/template/templates/gradle/kotlin/build.gradle.kts.eta
Outdated
Show resolved
Hide resolved
scripts/src/lib/template/templates/gradle/kotlin/build.gradle.kts.eta
Outdated
Show resolved
Hide resolved
scripts/src/lib/template/templates/gradle/kotlin/build.gradle.kts.eta
Outdated
Show resolved
Hide resolved
scripts/src/lib/template/templates/gradle/groovy/build.gradle.eta
Outdated
Show resolved
Hide resolved
CelDaemon
force-pushed
the
kotlin-dsl
branch
from
4b6ad86 to
a3258a3
Compare
This reverts commit 4bac270. Will create a separate PR for this patch after the Kotlin DSL has been merged.
CelDaemon
force-pushed
the
kotlin-dsl
branch
from
036e148 to
4c4ef68
Compare
CelDaemon
force-pushed
the
kotlin-dsl
branch
from
4c4ef68 to
f7f1f86
Compare
Contributor
Author
|
I have successfully ran the tests (158 passed), though with the Kotlin language disabled and an extra check to skip yarn on unobfuscated versions. 
|
Changes property access to use Gradle property providers instead of project property binding. Using Gradle properties in this way avoids issues when using Isolated Projects (gradle/gradle#32398). An alternative is to use `project.property(...)` instead, which is closer to the Groovy variant but does exhibit these issues.
Shares the gradle.properties.eta file between the Groovy and Kotlin DSL build script types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike the other PR, this one tries to stay as similar as possible to the Groovy build script.
The biggest differences are:
settings.gradle.ktsfileThis PR also fixes building Kotlin projects, as a deprecation seemed to prevent Gradle from configuring the project properly.
P.S.
I'm not entirely sure about the camel case properties, it causes the names to not match up with what is displayed on the site. If it is deemed unwanted, I'd be happy to revert them.