Update mod to Minecraft snapshot 24w40a#4136
Merged
modmuss50 merged 5 commits intoFabricMC:1.21.2from Oct 2, 2024
Merged
Conversation
modmuss50
added
port
modmuss50
approved these changes
Oct 2, 2024
Member
modmuss50
left a comment
modmuss50
left a comment
There was a problem hiding this comment.
Looks great, I cannot reproduce the crash, im happy to release it as-is. The recipe stuff can be improved over the coming weeks.
Contributor
Author
|
I can try to reproduce the crash again later. The only differences I can think of that my environment may have is worlds with feature flags enabled and the test worlds from #4118. I do realize that the pale oak chest boat is missing from the |
Member
Fixed both, thanks. I have tried worlds with the experiments enabled and all seems fine. Ill release this now and we can always fix the crash later. |
haykam821
commented
Oct 2, 2024
.../java/net/fabricmc/fabric/impl/tag/convention/datagen/generators/EntityTypeTagGenerator.java
Outdated
Show resolved
Hide resolved
haykam821
commented
Oct 2, 2024
.../java/net/fabricmc/fabric/impl/tag/convention/datagen/generators/EntityTypeTagGenerator.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request ports Fabric API to Minecraft snapshot 24w40a without any breaking changes.
In addition, the
c:is_dark_forestbiome tag has been added. This biome tag includes the dark forest and pale garden biomes, as the latter is a variant of the former, as stated by the Minecraft changelog:The game runs, but when creating a new world after exiting another world, the game may crash with the message
Caused by: java.lang.IllegalStateException: Tags already captured, this should not happen.