Add shift_arithmetic_left for signed integers#4112
Draft
remix7531 wants to merge 1 commit intoFStarLang:masterfrom
Draft
Add shift_arithmetic_left for signed integers#4112remix7531 wants to merge 1 commit intoFStarLang:masterfrom
remix7531 wants to merge 1 commit intoFStarLang:masterfrom
Conversation
Add shift_arithmetic_left to FStar.Int and FStar.Int{8,16,32,64,128}.
This performs a left shift on the two's complement representation
without requiring the input to be non-negative.
The existing shift_left requires 0 <= a, matching C semantics where
left-shifting a negative signed integer is undefined behavior.
shift_arithmetic_left accepts any signed integer, matching the
semantics of << on signed integers in Rust and C++20+.
Changes:
- FStar.Int.fsti: definition + two bit-level lemmas
- FStar.Int.fst: trivial proofs for the lemmas
- .scripts/FStar.IntN.fstip: val + infix operator (<<<^)
- .scripts/FStar.IntN.fstp: implementation
- Regenerated FStar.Int{8,16,32,64,128}.{fsti,fst} via mk_int.sh
This commit was created with the assistance of Claude (Anthropic).
Contributor
Author
|
The name Alternatives considered, open to suggestions on naming:
Relaxing the precondition on the existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add shift_arithmetic_left to FStar.Int and FStar.Int{8,16,32,64,128}. This performs a left shift on the two's complement representation without requiring the input to be non-negative.
The existing shift_left requires 0 <= a, matching C semantics where left-shifting a negative signed integer is undefined behavior. shift_arithmetic_left accepts any signed integer, matching the semantics of << on signed integers in Rust and C++20+.
Changes:
This commit was created with the assistance of Claude (Anthropic).