Make AddTypeCreator func and some ContentTypeReader related classes public for AOT#529
Open
Aranda wants to merge 1 commit intoFNA-XNA:masterfrom
Open
Make AddTypeCreator func and some ContentTypeReader related classes public for AOT#529Aranda wants to merge 1 commit intoFNA-XNA:masterfrom
Aranda wants to merge 1 commit intoFNA-XNA:masterfrom
Conversation
Member
|
Aren't these covered by adding them to rd.xml? |
Author
|
Ah, let me try that out and I'll close this if so. |
flibitijibibo
force-pushed
the
master
branch
2 times, most recently
from
a287f9a to
e0fbaf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
On AOT platforms, we need to manually add these type creator functions for all of our content type readers so that they can be found (without reflection) when loading the binary-serialized XML content. I'm hoping it's not controversial to make these public so we don't have to maintain custom branch when updating FNA. Thanks!