Skip to content

Comments

Feature: disable "not affected by displacement" 2026#517

Merged
MiquelAdell merged 9 commits intodevelopment-project-configuratorfrom
feature/disable-bvFA7fsiN3T-2026
Jan 15, 2026
Merged

Feature: disable "not affected by displacement" 2026#517
MiquelAdell merged 9 commits intodevelopment-project-configuratorfrom
feature/disable-bvFA7fsiN3T-2026

Conversation

@gqcorneby
Copy link

📌 References

📝 Implementation

  • disable checkboxes that involve the category option bvFA7fsiN3T and if project startdate is 2026

📹 Screenshots/Screen capture

2025-12-10.21-49-16.mp4

🔥 Notes to the tester

@bundlemon
Copy link

bundlemon bot commented Dec 10, 2025

BundleMon

No change in files bundle size

Groups updated (1)
Status Path Size Limits
Build Folder
./**/*
996.25KB (+885B +0.09%) +20%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@MiquelAdell MiquelAdell requested a review from eperedo December 11, 2025 09:41
Copy link
Contributor

@eperedo eperedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments, none of them affect functionality so I'm approving.

@@ -1,4 +1,4 @@
import React from "react";
import React, { CSSProperties } from "react";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, but we normally only import "React" and then use the properties directly React.CSSProperties.

@gqcorneby
Copy link
Author

Hi @MiquelAdell! I've added the fix for the following reported issues

  1. grey fields not disabled when editing
  2. disabled fields still visible in data entry app
2026-01-13.15-21-49.trimmed.mp4
2026-01-13.15-25-30.mp4

@gqcorneby
Copy link
Author

gqcorneby commented Jan 14, 2026

Hi @eperedo and @MiquelAdell! I'm requesting review again because there's been some changes that I think aren't minor. Here are the issues being addressed:

  1. grey fields not disabled when editing - dataSet.project.startDate was empty
  2. disabled fields still visible in data entry app - need to set dataSet.disabledField

I had to update the approach to add disabled fields upon selection of the indicators so the disabling isn't dependent the using allowing step 4 to load. Note: user can jump from one step to another after first pass.

2026-01-14.16-23-29.mp4

@MiquelAdell MiquelAdell merged commit d5562c3 into development-project-configurator Jan 15, 2026
6 checks passed
@MiquelAdell MiquelAdell deleted the feature/disable-bvFA7fsiN3T-2026 branch January 15, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants