UPD : Added pyproject.toml, setup.cfg and __init__.py #39
Open
wbjeon2k wants to merge 1 commit intoEugenHotaj:masterfrom
Open
UPD : Added pyproject.toml, setup.cfg and __init__.py #39wbjeon2k wants to merge 1 commit intoEugenHotaj:masterfrom
wbjeon2k wants to merge 1 commit intoEugenHotaj:masterfrom
Conversation
… pip install and easier access.
EugenHotaj
approved these changes
Aug 23, 2024
Owner
EugenHotaj
left a comment
EugenHotaj
left a comment
There was a problem hiding this comment.
Thanks @wbjeon2k for adding!
| @@ -0,0 +1 @@ | |||
| # empty __init__.py for easier access to models No newline at end of file | |||
Owner
There was a problem hiding this comment.
All the models are already importable with pytorch_generative.models.<model-name>. Is that not working for you?
| @@ -0,0 +1,33 @@ | |||
| ; modified from example https://xebia.com/blog/a-practical-guide-to-setuptools-and-pyproject-toml/ | |||
Owner
There was a problem hiding this comment.
Maybe get rid of the comments in this file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear EugenHotaj,
Hello EugenHotaj, I appreciate your work. Thank you for sharing this repository.
I added
pyproject.toml,setup.cfg, and__init__.pyfilesto enable pip install and easier access to models.
As these files were written for the minimum working example,
you may have to revise some of the information in those files.
Thank you.