Conversation
imalcolm1
commented
Apr 28, 2026
| </ItemGroup> | ||
|
|
||
| <MSBuild Projects="@(WPFProject)" Targets="Build" Properties="Configuration=$(Configuration);TargetFramework=$(_NetWindowsTarget);Platform=x64" /> | ||
| <MSBuild Projects="@(WPFWAPProject)" Targets="Restore" Properties="Configuration=$(Configuration);ArcGISMapsSDKVersion=$(ArcGISMapsSDKVersion)" /> |
Collaborator
Author
There was a problem hiding this comment.
Since we are moving away from using Visual Studio for the builds, we are going to need to find another way to package the WPF viewer as a store build. For now we're removing the WAP builds, and will make an internal issue to fix this before the next release. We can always build the store package manually
dotMorten
approved these changes
Apr 29, 2026
…lue being treated as new properties when passed to msbuild.dll
2346528 to
2fb07ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes dependency on Visual Studio and uses the dotnet-install.ps1 script to install dotnet in the jenkins workspace.
Type of change
Platforms tested on
Checklist