Skip to content

Visibility feature tweaks#1111

Merged
fbacall merged 1 commit intomasterfrom
clarify-visibility
Jun 6, 2025
Merged

Visibility feature tweaks#1111
fbacall merged 1 commit intomasterfrom
clarify-visibility

Conversation

@fbacall
Copy link
Member

@fbacall fbacall commented Jun 5, 2025

Summary of changes

  • Allow event/material visibility checkbox to be disabled
  • Display the hint at all times, without requiring hover
  • I18n

Motivation and context

A user wasn't clear about what the checkbox does, and it is the first thing you see on the new event form

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

* Display hint without requiring hover
* I18n
@fbacall fbacall requested a review from Copilot June 5, 2025 16:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the visibility feature for events and materials by updating locale strings and conditionally rendering the visibility checkbox input based on a configuration flag.

  • Updated i18n content in en.yml to improve clarity about visibility.
  • Modified both event and material form views to display the hint at all times and conditionally render the visibility input.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
config/locales/en.yml Revised locale strings for better clarity in event/material visibility settings.
app/views/materials/_form.html.erb Updated conditional rendering for the visibility checkbox using hint text.
app/views/events/_form.html.erb Updated conditional rendering for the visibility checkbox using hint text.

@fbacall fbacall merged commit 23991c3 into master Jun 6, 2025
11 checks passed
@fbacall fbacall deleted the clarify-visibility branch June 16, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants