Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
Looks like doc build is still failing |
|
Is there a faster way to check the doc build than going into the build log and downloading the artifact? |
I usually test on my local computer and then only push the commits. |
|
BTW, the earlier build was failing saying the following: |
|
Just noticed the same thing in Eelbrain/Eelbrain#100 It could be because |
|
Try again using the latest Eelbrain release (it's on conda forge). |
|
@christianbrodbeck yes! It worked like charm! Thanks! BTW, what would be a better way of organizing the gallery? I can think of making a |
christianbrodbeck
left a comment
There was a problem hiding this comment.
BTW, what would be a better way of organizing the gallery? I can think of making a dataloader to do the repetitive work at the beginning.
I think people will actually appreciate a few complete examples, giving all the steps from raw data. I think I see a few places where we could make this more streamlines and I will make a PR with suggestions into this PR.
Separately, I think we'll want a second set of examples working on whole BIDS datasets, there all the preprocessing will be handled by the pipeline and we can focus right on the results. We'll have to think logistically about how we will handle those builds (since they'll take much longer). Maybe a separate website where we push manually?
Quick check whether I got that correctly: events_bad_01.csv marks noisy segments in the data, but we're not actually using that information, right? (cf. #41)
The code line length is currently longer than the display area in some places, but I think we'll address that later with #19
|
@christianbrodbeck how does the example look now? |
christianbrodbeck
left a comment
There was a problem hiding this comment.
Just a few stylistic suggestions and questions, thanks @proloyd !
|
Actually, another issue: the brain is not
|
Co-authored-by: Christian Brodbeck <[email protected]>
|
@christianbrodbeck Thanks for the stylistic suggestions, I incorporated all of them. Regarding the |
|
@christianbrodbeck ready for your review. |
|
Counterintuitive result that frequent tones have a stronger response than oddballs. Is that also the case in an evoked response analysis? |
|
@christianbrodbeck Are we waiting for |
|
We don't need to, we could update that CI to work with the alpha build of Eelbrain which is on conda-forge. I was waiting for clarifying which response is frequent and which is infrequent :) |
|
@proloyd any thoughts on the discrepancy? |
|
@yaylim, @gokuprasanna Thanks!
@christianbrodbeck your thoughts?
|
|
Interesting, both changes are good calls. Still does not look like a classical mismatch response (e.g. https://doi.org/10.1016/j.clinph.2008.11.029). @yaylim any progress on the evoked response analysis? |
|
If you scroll down, the Brainstorm tutorial has pictures of what we're expecting in sensor and source space. Still, I think It would be good to align our expectations for NCRF from a sensor space analysis using all the same preprocessing parameters. There's also an opportunity for source localizing MMN and P300. |
|
@christianbrodbeck still checking the CTF analysis example on the MNE website, I'll check the brainstorm tutorial to double check the results, should be done by tomorrow. Thanks for the info! |
|
@christianbrodbeck @yaylim I also added ERF analysis as part of the example: |








Adds a Volume Source example to Sphinx-gallery.
Addresses #20 (comment)
@christianbrodbeck need your opinion on the organization.