Change the connection string parser inside the ConnectionSettings class to prevent reinventing the wheel #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectionsettings # Conflicts: # src/Ev.ServiceBus.Abstractions/Configuration/ConnectionSettings.cs # src/Ev.ServiceBus.Abstractions/Configuration/Extensions/ClientOptionsExtensions.cs # src/Ev.ServiceBus.Abstractions/Configuration/ServiceBusSettings.cs
…properties in the ConnectionSettings class.
benspeth
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves code quality and maintainability by replacing a custom connection string parser with the official Azure SDK implementation
ServiceBusConnectionStringProperties.Parse().Why? The Azure SDK parser is thoroughly tested by Microsoft and handles all edge cases, encoding issues, and future connection string format changes automatically. No need to maintain custom parsing logic. Updates to connection string format will be handled by SDK updates.
Unit test now uses proper fake connection string.
I also moved the class to the
Ev.ServiceBus.Abstractions.Configurationnamespace.UPDATE:
I don't think we need to use the absolute URI (sb://<URL>/) to connect to Microsoft Entra ID. We only need the fully qualified name (FQN).
Source: Authenticate a managed identity with Microsoft Entra ID to access Azure Service Bus resources