Skip to content

Minor changes#3361

Merged
Ghabry merged 12 commits intoEasyRPG:masterfrom
Ghabry:updates
Mar 17, 2025
Merged

Minor changes#3361
Ghabry merged 12 commits intoEasyRPG:masterfrom
Ghabry:updates

Conversation

@Ghabry
Copy link
Copy Markdown
Member

@Ghabry Ghabry commented Mar 3, 2025

Various mini changes not worth individual PRs.

Also contains the Android 2.32.2 bump.

Fix #3367

@Ghabry Ghabry added this to the 0.8.1 milestone Mar 3, 2025
@github-actions github-actions bot added Android Window/Scenes Bitmaps Building Settings All about customizable features, storing and applying them labels Mar 3, 2025
@florianessl
Copy link
Copy Markdown
Member

Another minor thing:
window_battlecommand.h/window_battlecommand.cpp seemingly has been obsolete for a long time & could be removed from the codebase.

@Ghabry Ghabry marked this pull request as ready for review March 10, 2025 18:35
namespace {
// hashes of known RPG_RT startup logos
std::array<uint32_t, 33> logo_crc32 = {
std::array<uint32_t, 36> logo_crc32 = {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With c++17 we can use type deduction and remove the explicit array size.

std::array logo_crc32{ val1, val2, ... };

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. I had to add u suffix to all the hex numbers because some of them are unsigned but this is much better than counting :).

@Ghabry Ghabry merged commit efc104e into EasyRPG:master Mar 17, 2025
14 checks passed
@Ghabry Ghabry deleted the updates branch March 17, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Android Battle Bitmaps Building Fonts Settings All about customizable features, storing and applying them Window/Scenes

Development

Successfully merging this pull request may close these issues.

Android: SDL Error

3 participants